Fix: MPI-Distribution w/o SC #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
bug
ax3l
commented
Jan 10, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ax3l
commented
Jan 23, 2024
ax3l
force-pushed
the
fix-mpi-no-sc
branch
6 times, most recently
from
b12b65c
to
f130791
Compare
ax3l
changed the title
- Ensure every MPI rank w/o space charge has a block, by limiting the `max_grid_size`, too. - Avoid Redistributing w/o space charge. - Expose blocking factor control to Python.
Add blocking factor for very small sims. Slightly adjust tolerance for MPI run.
ax3l
commented
Jan 30, 2024
| gid = *it; | ||
| } | ||
| } | ||
| auto& particle_tile = DefineAndReturnParticleTile(lid, gid, tid); |
There was a problem hiding this comment.
@atmyers @WeiqunZhang for ParIter loops after initialization, with OpenMP parallelism, does it matter which tid we use?
Or will be have now always one tile and no on-rank parallelism?
There was a problem hiding this comment.
(Please note we never call pc.Redistribute() in this mode)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without space charge, we can simply split the particles up during init in equal chunks and leave them there forever.
This fixes grid generation by setting the
max_grid_sizeto the AMReXblocking_factor(if not set by the user). Also, this avoids all calls toResizeMesh()andRedistributefor now.Fix #503