Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake Python IPO Control #644

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jul 17, 2024

pybind11::lto is only defined if CMAKE_INTERPROCEDURAL_OPTIMIZATION is not set in pybind11Common.cmake. Package managers like Spack use the latter.

@ax3l ax3l added bug Something isn't working bug: affects latest release Bug also exists in latest release version install component: python Python bindings labels Jul 17, 2024
@ax3l ax3l mentioned this pull request Jul 17, 2024
1 task
`pybind11::lto` is only defined if `CMAKE_INTERPROCEDURAL_OPTIMIZATION`
is not set in `pybind11Common.cmake`. Package managers like Spack
use the latter.
@ax3l ax3l enabled auto-merge (squash) July 17, 2024 22:53
@ax3l ax3l merged commit 311621f into ECP-WarpX:development Jul 17, 2024
15 of 16 checks passed
@ax3l ax3l deleted the fix-py-ipo-cmake branch July 18, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: python Python bindings install
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants