Add ref_particle charge & mass as user options in dashboard #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proy30
changed the title
|
UI look - 9/29[ |
Created additional_conditions variable to handle cases where validation is more than checking value_type
…d-ref-particle_user_inputs
proy30
changed the title
ax3l
reviewed
Oct 3, 2024
| @@ -53,7 +53,9 @@ def run_simulation(): | |||
| # reference particle | |||
There was a problem hiding this comment.
In a follow-up PR, run_simulation() really needs to be moved into a more well-named file than Analyze/plot_PhaseSpaceProjections/phaseSpace.py please :)
There was a problem hiding this comment.
Agree, addressed in #725!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dashboard currently does not support this and has ref. particle charge/mass hard-coded to -1.0 and 0.510998950 respectively.