-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2040 Build System Overhaul #2041
Conversation
Going to do a handover to black (New Maintainer Preference)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the new Installer to install EDMC over an older version (which was installed using the old Installer) causes a separate entry in the Windows Apps list to be created. The new entry has a different name (EDMarketConnector + Version) and instead of the EDMC icon a default program icon.
Additionally uninstalling one of the two entries leaves some residual files behind (depending on which one the Start Menu entry, Uninstaller Files, AppData files etc.) and the new Installer will require a full system reboot before installing EDMC.
Co-authored-by: Phoebe <40956085+C1701D@users.noreply.github.com>
Co-authored-by: Phoebe <40956085+C1701D@users.noreply.github.com>
Co-authored-by: Phoebe <40956085+C1701D@users.noreply.github.com>
307f452
to
9662473
Compare
Removes installed versions of EDMC which use the old WiX build framework
Description
This Pull includes an overhaul of the current build system, particularly handing off of WiX based systems and a streamlined, more feature-rich installer.
Hands over the installer system to the Inno Setup installer
This allows us to provide a smaller installer file, and provide a platform to provide further expansion and options.
This system is compatible with the existing auto-updater system, and will only require minor changes to the fields already in the XML updater file.
Further edits to documentation may be required as the documentation overhaul goes forth.
As this is only the build system being altered, and post-installed functionality is not changed, this is not a public API-breaking change.
Fixes #2040
Full Changes:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration