Get MacOS working as well as we can. #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Else the blind deletion of the shipyard key at startup causes a fatal exception.
In the scenario of the default Journals location not even existing the user needs might update it to a network mount. When they do so we attempt, and fail, to unlock the old location, despite it not being locked. So now we have this boolean so we know if we should even attempt unlocking.
|
NB: There was also something weird with a loooooooooong delay before it popped up Safari for the Frontier Authorisation after I'd changed the Journals location. That may well not be MacOS-specific though. |
On darwin this comes back with the type `__NSCFArray`, which I can't
find the definition of (in order to test against it). So instead let's
check that `res` is not-None, and not one of `str` or `int`, because
then it should be (meant to be) `list`.
Yes, this is weird given the pre-rewrite code is:
```python
def get(self, key: str) -> Union[None, list, str]:
"""Look up a string configuration value."""
val = self.settings.get(key)
if val is None:
return None
elif isinstance(val, str):
return str(val)
elif isinstance(val, list):
return list(val) # make writeable
else:
return None
```
But maybe something changed since 3.43 was tested and built.
A-UNDERSCORE-D
requested changes
Mar 13, 2021
A-UNDERSCORE-D
approved these changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
darwinconfig.delete() not respectingsuppressargument fixed.There's still an issue with the whole hotkey code not working because the application needs a MacOS permission to generally monitor keyboard input. The old way to grant this has changed in Catalina. There's "Input Monitoring" but I can't find any way to add an arbitrary app to it. We might need to find how to get the EDMC code to explicitly make the request so that the user can grant it.
And even then I'm not sure the current way of doing hotkeys on
darwinis the recommended way on Catalina. It's going to take a lot of study of the code to discern what is just the tk input monitoring and what is specifici MacOS calls.