Update CI/CD workflows for updating dependencies #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependabot: - Repeat the jobs with 'release/pydantic-v1-support' as the target branch. CI - Check dependencies: - Add a user input when manually running the workflow to determine the target branch to check pyproject.toml dependencies in as well as open a PR against.
Add a new job to also run the callable SINTEF/ci-cd workflow against the 'release/pydantic-v1-support' branch. Change the use of the `workflow_dispatch` input 'target_branch' so that it's checked against the triggering event being 'schedule'. Essentially, now: - When triggered by 'schedule', both jobs should run, creating 2 PRs, one against 'ci/dependabot-updates' & one against 'release/pydantic-v1-support'. - When manually triggered, only one of the jobs should run, creating either a PR against 'ci/dependabot-updates' OR against 'release/pydantic-v1-support'. Both jobs should always still only run for the original repository, i.e., not for forks - this is unchanged from previous iterations.
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #351 +/- ##
==========================================
- Coverage 82.16% 82.08% -0.09%
==========================================
Files 44 44
Lines 1211 1211
==========================================
- Hits 995 994 -1
- Misses 216 217 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CasperWA
requested review from
Treesarj and
daniel-sintef
and removed request for
Treesarj
daniel-sintef
approved these changes
Oct 6, 2023
Also, fix ignore rules by: - Using `=` instead `==` to denote 'version' values. - Only add ignore rules for dependencies with an explicit upper limit.
daniel-sintef
approved these changes
Oct 6, 2023
Co-authored-by: Daniel Marchand <Daniel.Marchand@sintef.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Closes #349
Dependabot
Repeat the jobs with 'release/pydantic-v1-support' as the target branch.
CI - Check dependencies
Add a user input when manually running the workflow to determine the target branch to check pyproject.toml dependencies in as well as open a PR against.
Add a new job to also run the callable SINTEF/ci-cd workflow against the 'release/pydantic-v1-support' branch.
Change the use of the
workflow_dispatchinput 'target_branch' so that it's checked against the triggering event being 'schedule'.Essentially, now:
'release/pydantic-v1-support'.
Both jobs should always still only run for the original repository, i.e., not for forks - this is unchanged from previous iterations.
Future
Changes are already in the works for the ignore rules in CI - Check dependencies when migrating to pydantic v2 (see #330), the split into two CI jobs here will accommodate this difference as well.
This means, depending on the merge order, either this PR or #330 should be updated accordingly.
Type of change:
Checklist for the reviewer:
This checklist should be used as a help for the reviewer.