-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sparqlwrapper backend #11
Conversation
- documented return value of Triplestore.query() method - improved documentation of arguments of query() and update() methods - ensure that the tests runs again - corredted return value of the query() method (for rdflib backend) and added tests
This is part of another PR and should not be here.
Codecov ReportBase: 72.94% // Head: 72.27% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 72.94% 72.27% -0.68%
==========================================
Files 10 11 +1
Lines 621 660 +39
==========================================
+ Hits 453 477 +24
- Misses 168 183 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -168,7 +168,7 @@ def serialize( | |||
self._check_method("serialize") | |||
return self.backend.serialize(destination=destination, format=format, **kwargs) | |||
|
|||
def query(self, query_object, **kwargs) -> "List[Tuple[str, ...]]": | |||
def query(self, query_object, **kwargs) -> "List[Triple]": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually not fully correct. The return value of query()
depends on the sparql query. It just returns a list of tuples for each match. The tuple is not a triple but contains as many fields as the query asks for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the original return value is correct?
Added initial drat implementation of a SPARQLWrapper backend.
In order to test the backend, This PR builds on top on PR #9.