Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for xsd:nonNegativeInteger literals #178

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Feb 21, 2024

Description:

  • Added support for xsd:nonNegativeInteger, since they occurs in cardinality restrictions.
  • Moved consistency checking of literals to the Literal constructor instead of in the to_python() method.
  • Added more tests to improve test coverage
  • Added tests for warnings (and ignored those coming from other packages)

Type of change:

  • Bug fix and code cleanup.
  • New feature.
  • Documentation update.
  • Testing.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.40%. Comparing base (9271898) to head (866e3ed).

Files Patch % Lines
tripper/literal.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   76.82%   77.40%   +0.57%     
==========================================
  Files          17       17              
  Lines        1536     1540       +4     
==========================================
+ Hits         1180     1192      +12     
+ Misses        356      348       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesper-friis jesper-friis mentioned this pull request Feb 29, 2024
9 tasks
@jesper-friis jesper-friis merged commit 0f65087 into master Mar 1, 2024
28 of 30 checks passed
@jesper-friis jesper-friis deleted the non-negative-integer branch March 1, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants