Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for finding literal triples #183

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Conversation

jesper-friis
Copy link
Contributor

Description:

Added test for finding literal triples.

That works, but it turned out that we need to support untyped literals. See issue #182

Type of change:

  • Bug fix and code cleanup.
  • New feature.
  • Documentation update.
  • Testing.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@jesper-friis jesper-friis linked an issue Feb 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.47%. Comparing base (c18a9f1) to head (614736e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   77.40%   77.47%   +0.07%     
==========================================
  Files          17       18       +1     
  Lines        1540     1545       +5     
==========================================
+ Hits         1192     1197       +5     
  Misses        348      348              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesper-friis jesper-friis removed the request for review from francescalb March 1, 2024 09:30
@jesper-friis jesper-friis merged commit 4314f40 into master Mar 4, 2024
16 checks passed
@jesper-friis jesper-friis deleted the 179-search-for-literals branch March 4, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search with ts.triples() doesn't recognise literals
2 participants