Bump basic CI tests and CD to python 3.9 #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajeklund
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
=======================================
Coverage 77.47% 77.47%
=======================================
Files 18 18
Lines 1545 1545
=======================================
Hits 1197 1197
Misses 348 348 ☔ View full report in Codecov by Sentry. |
|
This PR has not been tested yet; should be done before merging. |
The basic tests do not test the functionality of the code, but rather runs the developer tools, builds the package distribution and the documentation. Since the builds will be done using Python 3.9, this is in alignment. Note, this does not affect the ability to use Python 3.7 or 3.8 when installing and using the built package.
|
I've bumped the Python version used for the basic CI tests to Python 3.9. This ensures we test building the package distribution and documentation in the same Python version as is being used upon a release. This does not impact the ability to install and use the built package in Python 3.7 or 3.8. |
CasperWA
approved these changes
Mar 8, 2024
|
@ajeklund "squash and merge" at will :) |
ajeklund
changed the title
ajeklund
deleted the
191-publish-workflow-fails-because-it-uses-python-37
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because documentation will no longer build on python 3.7, we bump its release job together with the package build from 3.7 to 3.9. Closes #191.
While at it, we also bump the basic CI tests to 3.9. This does not impact the ability to install and use the built package in Python 3.7 or 3.8.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.