Allow string literal to compare equal to strings. #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is both a more intuitive behaviour and allow the mappings module to behave as expected when using string literals as dict keys.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #215 +/- ##
=======================================
Coverage 78.42% 78.42%
=======================================
Files 18 18
Lines 1650 1650
=======================================
Hits 1294 1294
Misses 356 356 ☔ View full report in Codecov by Sentry. |
10 tasks
francescalb
approved these changes
May 27, 2024
jesper-friis
added a commit
that referenced
this pull request
May 27, 2024
# Description Correct parsing literals from the rdflib backend. The failing test should be fixed by PR #215. ## Type of change - [x] Bug fix and code cleanup - [ ] New feature - [ ] Documentation update - [ ] Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow string literal to compare equal to strings.
This should be considered a bug fix rather than a new feature that changes the behaviour of Tripper, since it allow the mappings module to behave as expected when using string literals as dict keys, fixing a failure in the mapping example of DLite.
This is also a more intuitive behaviour and is consistent with RDF 1.1 and later.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.