-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved the handling of different return types from the query() method #219
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #219 +/- ##
==========================================
- Coverage 78.46% 78.34% -0.13%
==========================================
Files 18 18
Lines 1672 1690 +18
==========================================
+ Hits 1312 1324 +12
- Misses 360 366 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but should we maybe have tests for the different types of queries?
SELECT, ASK, CONSTRUCT and DESCRIBE queries.
For more information, see https://pre-commit.ci
…o query-return-types
For more information, see https://pre-commit.ci
…o query-return-types
Description
Improved and documented the handling of different return types from the query() method.
Note that not all lines that codecov complains about are possible to test simultaneously, because the SPARQL interface in tripper.backends.rdflib supports multiple versions of rdflib.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.