Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the handling of different return types from the query() method #219

Merged
merged 16 commits into from
Jun 22, 2024

Conversation

jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented May 27, 2024

Description

Improved and documented the handling of different return types from the query() method.

Note that not all lines that codecov complains about are possible to test simultaneously, because the SPARQL interface in tripper.backends.rdflib supports multiple versions of rdflib.

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.34%. Comparing base (cbcccab) to head (c6811b3).

Files Patch % Lines
tripper/backends/rdflib.py 62.50% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   78.46%   78.34%   -0.13%     
==========================================
  Files          18       18              
  Lines        1672     1690      +18     
==========================================
+ Hits         1312     1324      +12     
- Misses        360      366       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but should we maybe have tests for the different types of queries?
SELECT, ASK, CONSTRUCT and DESCRIBE queries.

@jesper-friis jesper-friis merged commit f7488f5 into master Jun 22, 2024
17 of 19 checks passed
@jesper-friis jesper-friis deleted the query-return-types branch June 22, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants