Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the last warning in the tests #226

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Get rid of the last warning in the tests #226

merged 3 commits into from
Jun 24, 2024

Conversation

jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Jun 22, 2024

Description

Get rid of the last warning when running the tests.

Type of change

  • Bug fix and code cleanup
  • New feature
  • Documentation update
  • Testing

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?
  • Is the code properly tested?

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.41%. Comparing base (590eb5d) to head (8894ae4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   78.41%   78.41%           
=======================================
  Files          18       18           
  Lines        1696     1696           
=======================================
  Hits         1330     1330           
  Misses        366      366           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesper-friis jesper-friis merged commit 3f15781 into master Jun 24, 2024
19 checks passed
@jesper-friis jesper-friis deleted the no-warnings branch June 24, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants