Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the proper version of SINTEF/ci-cd #36

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Conversation

CasperWA
Copy link
Contributor

@CasperWA CasperWA commented Nov 17, 2022

Closes #33
Closes #35

Return to using v1 for SINTEF/ci-cd callable workflows.
Add missing type annotations to ensure warning-free documentation build.

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022

Codecov Report

Base: 73.57% // Head: 73.41% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (a9c13e4) compared to base (95f1d4c).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   73.57%   73.41%   -0.17%     
==========================================
  Files          10       10              
  Lines         598      598              
==========================================
- Hits          440      439       -1     
- Misses        158      159       +1     
Impacted Files Coverage Δ
tripper/literal.py 83.33% <33.33%> (-1.42%) ⬇️
tripper/utils.py 77.14% <100.00%> (-0.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Satisfy mypy, ensuring correct typing.
@CasperWA CasperWA marked this pull request as ready for review November 17, 2022 11:14
daniel-sintef
daniel-sintef previously approved these changes Nov 22, 2022
Copy link
Contributor

@daniel-sintef daniel-sintef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but please add a small comment in the code where I have requested it. (Or disagree that we need it and we can have a discussion)

@CasperWA CasperWA merged commit d94771f into main Nov 22, 2022
@CasperWA CasperWA deleted the cwa/close-33-type-annotations branch November 22, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert to using the proper general version for SINTEF/ci-cd Write in type annotations
3 participants