Added collection backend #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 72.38% // Head: 74.25% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 72.38% 74.25% +1.87%
==========================================
Files 11 12 +1
Lines 659 703 +44
==========================================
+ Hits 477 522 +45
+ Misses 182 181 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
quaat
requested changes
Dec 1, 2022
quaat
approved these changes
Dec 2, 2022
Closed
jesper-friis
added a commit
that referenced
this pull request
Dec 3, 2022
…ing tests. Reduced code dublication. Hopefully addressed comments by Thomas in PR #44
Merged
jesper-friis
added a commit
that referenced
this pull request
Dec 13, 2022
* Improved generality of parse_literal() and parse_object() fixing failing tests. Reduced code dublication. Hopefully addressed comments by Thomas in PR #44 * Added __hash__() and __eq__() methods to Literal and fixed some tests. * Added __hash__() and __eq__() to Namespace as well. * Added test to infer IRI from pydantic datamodel * Added a pylint disable because of yet another bug in pylint * Changed `uri` to `identity` to match soft7 datamodels * Added comment * Also handle blank nodes correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41
Simple backend providing a tripper interface to DLite collections. Will be used by oteapi when DLite is chooses as interoperability platform.
This PR also include tests for utils.py - they are written as a script since they are so simple that test isolation via pytest is not needed.
Note this is a minimal implementation. Support for prefixes should be added in follow-up PRs.
Right now all triples are stored written out completely, but for the user of dlite, I guess it would be easier if the IRIs stored in the collection would be prefixed. This is a topic for a later PR, though.