Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the value optional + added some cleanup #70

Merged
merged 8 commits into from
Jan 27, 2023
Merged

Conversation

jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Jan 26, 2023

Support using mappings to build a workflow without executing it. In this case there are no need for explicit values, hence we make them optional.

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023

Codecov Report

Base: 67.13% // Head: 66.94% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (b492fb5) compared to base (314455d).
Patch coverage: 69.23% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   67.13%   66.94%   -0.19%     
==========================================
  Files          14       14              
  Lines        1065     1071       +6     
==========================================
+ Hits          715      717       +2     
- Misses        350      354       +4     
Impacted Files Coverage Δ
tripper/mappings/mappings.py 47.84% <69.23%> (-0.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

daniel-sintef
daniel-sintef previously approved these changes Jan 26, 2023
Copy link
Contributor

@daniel-sintef daniel-sintef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify the TODO a bit more before merging.

tripper/mappings/mappings.py Outdated Show resolved Hide resolved
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
@jesper-friis jesper-friis merged commit edfe936 into main Jan 27, 2023
@jesper-friis jesper-friis deleted the optional-values branch January 27, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants