Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external backends #80

Merged
merged 10 commits into from
Mar 11, 2023
Merged

Support external backends #80

merged 10 commits into from
Mar 11, 2023

Conversation

jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Feb 4, 2023

Description:

Add support for users to provide their own backends.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@jesper-friis jesper-friis linked an issue Feb 4, 2023 that may be closed by this pull request
@jesper-friis jesper-friis marked this pull request as draft February 4, 2023 20:33
@jesper-friis jesper-friis changed the title Support external backends WIP: Support external backends Feb 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023

Codecov Report

Base: 67.52% // Head: 67.36% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (7a20809) compared to base (68a30ed).
Patch coverage: 66.66% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   67.52%   67.36%   -0.17%     
==========================================
  Files          14       14              
  Lines        1124     1146      +22     
==========================================
+ Hits          759      772      +13     
- Misses        365      374       +9     
Impacted Files Coverage Δ
tripper/triplestore.py 75.49% <65.38%> (-1.28%) ⬇️
tripper/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jesper-friis jesper-friis marked this pull request as ready for review February 5, 2023 12:27
@jesper-friis jesper-friis changed the title WIP: Support external backends Support external backends Feb 5, 2023
@jesper-friis jesper-friis merged commit 02cc7f8 into main Mar 11, 2023
@jesper-friis jesper-friis deleted the 63-external-backends branch March 11, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add entrypoint system to link external backend implementation
4 participants