Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov #171

Closed
maelle opened this issue Aug 12, 2024 · 12 comments
Closed

codecov #171

maelle opened this issue Aug 12, 2024 · 12 comments
Assignees
Labels

Comments

@maelle
Copy link
Collaborator

maelle commented Aug 12, 2024

@salvafern do you have admin access to https://app.codecov.io/gh/EMODnet? I think the repo might need to be reactivated now that I renamed it.

@salvafern
Copy link
Collaborator

No I don't have admin access. @bart-v could you have a look?

@maelle
Copy link
Collaborator Author

maelle commented Aug 12, 2024

Beside possible reactivation, maybe we also need a token. It can be an organization wide secret (this way we won't need to ask again for emodnet.wcs) https://ropensci.org/blog/2024/05/24/ropensci-news-may-2024/#token-now-needed-for-code-coverage-via-codecov-and-covr-on-github-actions

@maelle
Copy link
Collaborator Author

maelle commented Aug 12, 2024

Now the badge is working but having the token might still be a good idea (I fear we might run into rate limits otherwise? Or maybe there is already an organization-side secret?)

@bart-v
Copy link

bart-v commented Aug 12, 2024

There was already an organization-side secret.
Since you asked for a new one, I overwrote it by one I generated
So probably it's broken now...
Can you test?

@maelle
Copy link
Collaborator Author

maelle commented Aug 12, 2024

Ok, thanks, sorry. Following https://github.com/EMODnet/emodnet.wfs/actions/runs/10353537203 now

@maelle
Copy link
Collaborator Author

maelle commented Aug 12, 2024

ah indeed "Not valid tokenless upload", the new token needs to be stored as new organization-wide secret. So sorry!!

@bart-v
Copy link

bart-v commented Aug 12, 2024

OK done, try now?

@bart-v bart-v added the CI label Aug 12, 2024
@maelle
Copy link
Collaborator Author

maelle commented Aug 13, 2024

Weirdly I got the same error again https://github.com/EMODnet/emodnet.wfs/actions/runs/10353537203/job/28690809753#step:6:46 🤔 (I can't explore more today, sorry)

@bart-v
Copy link

bart-v commented Aug 13, 2024

Seems a bug in codecov
codecov/codecov-action#1487
You need to use version 4.5.0 and not 4

@maelle
Copy link
Collaborator Author

maelle commented Aug 13, 2024

@bart-v
Copy link

bart-v commented Aug 13, 2024

OK, I now used the correct token, i.e. like here
codecov/codecov-action#1537
Seems to work

@maelle
Copy link
Collaborator Author

maelle commented Aug 13, 2024

thanks!!

@maelle maelle closed this as completed Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants