-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not valid tokenless upload #1487
Comments
@joseph-sentry do you mind taking a look here? |
@thomasrockhu-codecov since we made the API changes for the new tokenless, unless a user is using the updated CLI (which hasn't been released yet) and the updated action, tokenless won't work |
Hi, I encounter a similar issue. The new CLI version was released recently (https://github.com/codecov/codecov-cli/releases/tag/v0.7.0), but my problem still occurs. Here's the failed log of a fork PR in the stylelint repo (stylelint/stylelint#7777):
at https://github.com/stylelint/stylelint/actions/runs/9605083708/job/26494382161?pr=7777#step:7:16
at https://github.com/stylelint/stylelint/actions/runs/9605083708/job/26494382161?pr=7777#step:7:33
at https://github.com/stylelint/stylelint/actions/runs/9605083708/job/26494382161?pr=7777#step:7:44 It would be great if you could help. Thanks. 🙏🏼 |
In addition, here's a successful log with the CLI v0.6.0:
at https://github.com/stylelint/stylelint/actions/runs/9601142978/job/26479023288?pr=7776#step:7:33 |
Looks like this is introduced by the Codecov CLI v0.7.0. |
We have the same issue with Apport. Example failed upload: https://github.com/canonical/apport/actions/runs/9506858733/job/26508430770?pr=355 |
* Remove WaterTAP-specific how-to pages * Move existing files * Add core files for Sphinx docs * Add minimal installation instructions * Add ReadTheDocs config file * Reformat with Black * Add basic GHA check for docs build * Try resolving failures for Python 3.8 * Try fixing Codecov upload error * Try fixing workflow syntax error * Try with space * Try downgrading Codecov CLI due to codecov/codecov-action#1487
* Empty commit to test codecov/codecov-action#1487 * Specify Codecov CLI version to work around codecov/codecov-action#1487 * Add Codecov fix to MPI workflow Even though it'll be removed as part of #1345
Hi all, indeed tokenless uploads were broken for v0.7.0 of the CLI, we just released v0.7.1 which should fix that bug. If you've already versioned to v0.6.0, that should work fine as well. |
@joseph-sentry Thanks for the quick patch! I'll try it soon. 👍🏼 By the way, the release notes and the changelog link seem incorrect to me in https://github.com/codecov/codecov-cli/releases/tag/v0.7.1 because of too many items. 👀 |
@joseph-sentry Unfortunately, the problem doesn't seem to be resolved. 😢
https://github.com/stylelint/stylelint/actions/runs/9617068584/job/26528019385?pr=7783#step:7:44 EDIT: I confirmed v0.7.1 was used:
https://github.com/stylelint/stylelint/actions/runs/9617068584/job/26528019385?pr=7783#step:7:33 |
@ybiquitous would you mind trying to re-run again? I think this may have just been a caching thing on our side |
@thomasrockhu-codecov Switched to v0.7.2 and the upload is successful, thank you all for the quick response. |
@thomasrockhu-codecov - Also still not working over here: https://github.com/Pyomo/pyomo/actions/runs/9751098274/job/26913971560?pr=3303 |
I'm stuck on this as well. Specifying the
Here's the failing job: https://github.com/aravinda0/qtile-bonsai/actions/runs/9873228232/job/27272344047 |
In case this helps anyone else: our (Pyomo) problem was that we upload from multiple sources (GHA, Jenkins), and the uploader used on Jenkins was outdated / causing issues. Once we switched to a the |
Edit: It turns out I was using an older version, |
…1441) * Specify Codecov version to work around codecov/codecov-action#1487 * Try with v0.7.1 --------- Co-authored-by: Keith Beattie <ksbeattie@lbl.gov>
This issue has been patched. Please open a new issue if problems arise. |
@trent-codecov I'm still experiencing the issue, and I'm not sure what I need to upgrade in order to obtain the patch, if it has been released. I see the latest tag on this repo is from June, but maybe the fix was contributed in a dependency? |
@thomasrockhu-codecov that line is not used at all when using tokenless upload, is it? As you can see, that line does it job when the upload is not tokenless |
@thomasrockhu-codecov sorry for doubting you, the fix you suggested appears to work: doctrine/dbal#6501 I don't understand why, could you please explain? |
@greg0ire I actually need to dig in and figure it out for myself, but it smelled like an empty string vs null value thing. I would assume somewhere (probably CLI), we take "" to mean you want to use that as the token. That's probably a bug on our side, but I wanted to unblock you quickly. |
Thank you! |
@thomasrockhu-codecov I'm sad to say that this job failed with the infamous "Not valid tokenless upload". It contains my commit that removes the quotes, I checked. |
I don't think so, your outage was marked as resolved on |
I believe this has been happening for a few weeks now, but many of our PRs using tokenless upload (they are PRs from open source forks) fail with
Report creating failed: {"detail":"Not valid tokenless upload"}
Here is an example: https://github.com/doctrine/dbal/actions/runs/9554014292/job/26334506168
The text was updated successfully, but these errors were encountered: