Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor guess_layer_format() for more robustness #159

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Feb 28, 2024

Fix #158
Fix #157

@salvafern could you please have a look?

wfs <- EMODnetWFS::emodnet_init_wfs_client(service = "physics")
#> Loading ISO 19139 XML schemas...
#> Loading ISO 19115 codelists...
#> ✔ WFS client created successfully
#> ℹ Service: "https://prod-geoserver.emodnet-physics.eu/geoserver/ows"
#> ℹ Version: "2.0.0"
str(EMODnetWFS::emodnet_get_layer_info(wfs, layers = "EP_PLATFORMS_MO_ATLAS"))
#> rowws_df [1 × 9] (S3: rowwise_df/tbl_df/tbl/data.frame)
#>  $ data_source    : chr "emodnet_wfs"
#>  $ service_name   : chr "https://prod-geoserver.emodnet-physics.eu/geoserver/ows"
#>  $ service_url    : chr "physics"
#>  $ layer_name     : chr "EP_PLATFORMS_MO_ATLAS"
#>  $ title          : chr "EMODnet Physics - Moorings - ATLAS"
#>  $ abstract       : chr "EMODnet Physics DB of the mooring. Global collection. \r\nA mooring in oceanography is a collection of devices,"| __truncated__
#>  $ class          : chr "WFSFeatureType"
#>  $ format         : chr "data.frame"
#>  $ layer_namespace: chr "EMODnet"
#>  - attr(*, "groups")= tibble [1 × 1] (S3: tbl_df/tbl/data.frame)
#>   ..$ .rows: list<int> [1:1] 
#>   .. ..$ : int 1
#>   .. ..@ ptype: int(0)

Created on 2024-02-28 with reprex v2.1.0

@maelle maelle requested a review from salvafern February 28, 2024 11:25
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.20%. Comparing base (8b52b4d) to head (fbedf57).
Report is 8 commits behind head on main.

❗ Current head fbedf57 differs from pull request most recent head 805e8ee. Consider uploading reports for the commit 805e8ee to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
+ Coverage   86.43%   88.20%   +1.76%     
==========================================
  Files           9        9              
  Lines         339      339              
==========================================
+ Hits          293      299       +6     
+ Misses         46       40       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

R/info.R Show resolved Hide resolved
@maelle maelle merged commit 0480bb0 into main Mar 15, 2024
5 of 7 checks passed
@maelle maelle deleted the physics branch March 15, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with a layer of the physics server Could guess_layer_format() use ows4r's $getGeometryType()?
3 participants