Use go.ovirtsdk4 library to refactor the provider #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't see this get created. Is there a reason you closed it? |
|
Sorry for that. It's kind of misoperation that I deleted the branch. Reopen now. |
|
Nicely done. Thanks for contributing this! |
|
@jboero My pleasure. Thanks for your attention. You could see https://github.com/sinokylin/terraform-provider-ovirt for the latests progress. I will make contributions here stepwise. 😄 |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the golang sdk of ovirt-engine v4.x to refactor the
providerand existing resources/datasources.I tested OK with
terraform applyandterraform destroyin my local oVirt-v4.2 dev environment,Notice: Please poweroff the vm before modify the disk attributes, this will be fixed soon.