This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Support read only transactions 📦 #11020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmand push transaction
Test verifies new cleos option --return-failure-trace is accepted but does not test its functionality.
…8-support-read-only-transactions-develop-boxed
…en launching cluster
heifner
suggested changes
Jan 10, 2022
| } | ||
| } | ||
| next(read_only::push_ro_transaction_results{db.head_block_num(), db.head_block_id(), db.last_irreversible_block_num(), db.last_irreversible_block_id(), | ||
| accnt_metadata_obj.code_hash, pending_transactions, output}); |
There was a problem hiding this comment.
Should use std::move(pending_transactions)
There was a problem hiding this comment.
I think you missed this one.
plugins/amqp_trx_plugin/include/eosio/amqp_trx_plugin/fifo_trx_processing_queue.hpp
Outdated
Show resolved
Hide resolved
plugins/chain_plugin/include/eosio/chain_plugin/chain_plugin.hpp
Outdated
Show resolved
Hide resolved
…sactions-develop-boxed
heifner
reviewed
Jan 18, 2022
| } | ||
| next(read_only::push_ro_transaction_results{db.head_block_num(), db.head_block_id(), db.last_irreversible_block_num(), db.last_irreversible_block_id(), | ||
| accnt_metadata_obj.code_hash, pending_transactions, output}); |
There was a problem hiding this comment.
next always has to be called. It needs moved outside the if.
There was a problem hiding this comment.
Moved out of if, but compile failed. the parameter of next() need change, just paste the code that you want here to save the forth and back.
heifner
approved these changes
Jan 24, 2022
heifner
changed the title
softprofe
deleted the
kli-EPE-1898-support-read-only-transactions-develop-boxed
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Support read only transactions develop boxed. See EPE 1898.
Moving PR #10189 to develop-boxed. Solved the conflict and made some adaption for compile problem.
If any more eos PR need for read only query feature, will move in other PR. this PR just for move 10189.
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions