Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Progress on #7 and #123 #137

Merged
merged 29 commits into from
Aug 9, 2017
Merged

Progress on #7 and #123 #137

merged 29 commits into from
Aug 9, 2017

Conversation

nathanielhourt
Copy link
Contributor

Everything should be implemented, but still needs testing.

nathanielhourt and others added 23 commits August 1, 2017 13:14
@nathanielhourt
Partially revert 67c9b8b
eaef8b1 
Remove the changes around moving authorizations from Message to
Transaction, as we decided this is not the best way to go. See details
at #2 (comment)
@kalloc @nathanielhourt
Fix typo
824bea0
@kalloc @nathanielhourt
Temporary add help command
8b1fbf7 
1) add default command - help
2) prevent segfault
@peterwillcn @nathanielhourt
Adjust standard docker makefile
f30ccb0
@peterwillcn @nathanielhourt
Add packages for ci
aa057cc
@peterwillcn @nathanielhourt
Add build status
4592631
@iamaprotoss @nathanielhourt
merged apply, precondition and validate contexts into apply_context
9b98190
@nathanielhourt
Ref #7: Progress towards auth
9ad3260 
We now check authorization of transactions when they come in as pending,
and again when we apply them in some block (either when generating the
block or when applying it). When applying the transactions in a block,
we check auth for all transactions in the block prior to processing any.

To check auth, we first scan all of the declared authorizations, and
check that the authorization is sufficient to grant permission for the
given account to execute the given message type (TODO: look up the
actual required permission level rather than just assuming it's
'active'); then, check that the transaction bears signatures to confer
the declared authorization.
@nathanielhourt
Ref #7: Implement require_authorization, fix tests
0393f95 
Require_authorization is now implemented so as the contract executes and
asserts that a particular account approved the transaction, the chain
asserts that this is so and throws if not.

Also, update the tests, since the auth checks now bring to bear the rule
that an account cannot be used in the same block that creates it. The
tests now comply with this rule.

TODO:
 - Check that all declared authorizations get required by the contract
 - Implement the mapping from user permissions to message types
 - Use mapping of permission to message type in
lookup_minimum_permission
@nathanielhourt
Ref #7: Check all declared auths get required
ec03f1f
@nathanielhourt
Ref #123: Define types
94fc433 
Define the types documented in the issue.

TODO: Implement logic
@nathanielhourt
Ref #123: Implement lookup_minimum_permission
e4f3979 
Add docs on some of the types, register the index, and implement
chain_controller::lookup_minimum_permission.
@nathanielhourt
Ref #123: Rename requirepermission->linkauth
05550b8 
The name requirepermission was too long, so I renamed it linkauth
@nathanielhourt
Ref #123: Implement linkauth
8c5a0e7 
Implement the linkauth handler in the system contract
@nathanielhourt
Ref #123: Define/Implement unlinkauth
12dcd35 
Add an unlinkauth message type which removes a link from a message type
to a required authority
@nathanielhourt
Add satisfiability check to validate(Authority)
d78f1a6 
Add a check to the validate function on authority which checks that the
authority can be satisfied, which is to say, that the total of all the
weights meets or exceeds the threshold.
@nathanielhourt
Ref #123: Implement updateauth, deleteauth
fbff3c3 
Though not strictly part of issue 123, this is a necessary step in order
to complete #123. Rename UpdatePermission->updateauth and
DeletePermission->deleteauth, and implement them.

At this point, I think #123 is fully implemented and ready for testing.
@nathanielhourt
Add Complex_Authority test macro
d15ce5e 
Add a new testing helper macro, Complex_Authority, to create an
arbitrary Authority inline with a slightly less confusing syntax
@nathanielhourt
Ref #123: Test macros to set/delete auths
d6f89ca 
Create and smoke test Add_Authority and Delete_Authority test helper
macros
@nathanielhourt
Ref #123: Write tests, fix bugs
d4989d4
@nathanielhourt
Ref #123: Testing, fixing, 1 behavior change
6218ccb 
The behavior change is that I am forbidding changing a
permission_object's parent until we come up with a safe way to support
it. The issue is that it's possible to create loops by creating an
object A with an existing parent B, then setting B's parent to A. The
obvious solution is to ensure with every parent change that there is a
path back to the owner authority by following parents, but to do this we
need a tree depth limit. I haven't explored the implications of that, so
I'm just disabling parent changes for the time being. The user can
simply delete the old subtree and create a new one if he wants to move a
subtree from one parent to another.
@nathanielhourt
Use C++14, not 17
a210f9c 
Otherwise the build fails on my system
@nathanielhourt
Remove conflict marker that snuck past
4adbf0b
nathanielhourt and others added 4 commits August 8, 2017 14:28
@nathanielhourt
Merge branch 'master' into permission-links-123
8d0b97f
@nathanielhourt
Mark submodules 'ignore = dirty'
0ec8c9d
@nathanielhourt
Ref #123: Testing, fixing
806508a
@nathanielhourt
Ref #123: Add test macros, testing, and fixing
35c4740 
Add macros for Link_Authority and Unlink_Authority, write some initial
tests of these operations, and fix a bug (unlinkauth didn't require any
authority)
@nathanielhourt
Improve error message
f7c6021 
When rejecting a transaction due to excessive authorizations on a
message, include the authorizations which were not necessary in the
reported error
@pmesnier pmesnier self-assigned this Aug 9, 2017
@bytemaster bytemaster merged commit 5ccf1e4 into master Aug 9, 2017
ljrprocc pushed a commit to bithacks-tech/myeosio that referenced this pull request Jul 4, 2018
Merge pull request EOSIO#137 from enumivo/staging
a3e81ef 
cleanup
NorseGaud pushed a commit that referenced this pull request Jul 30, 2019
# This is a combination of 186 commits.
6c09577 
# This is the 1st commit message:

various improvements

# This is the commit message #2:

new hash

# This is the commit message #3:

fix for script path

# This is the commit message #4:

fixes

# This is the commit message #5:

fixes

# This is the commit message #6:

fixes

# This is the commit message #7:

fixes

# This is the commit message #8:

fixes

# This is the commit message #9:

fixes

# This is the commit message #10:

fixes

# This is the commit message #11:

fixes

# This is the commit message #12:

fixes

# This is the commit message #13:

fixes

# This is the commit message #14:

fixes

# This is the commit message #15:

fixes

# This is the commit message #16:

fixes

# This is the commit message #17:

fixes

# This is the commit message #18:

fixes

# This is the commit message #19:

fixes

# This is the commit message #20:

fixes

# This is the commit message #21:

fixes

# This is the commit message #22:

fixes

# This is the commit message #23:

fixes

# This is the commit message #24:

fixes

# This is the commit message #25:

fixes

# This is the commit message #26:

testing

# This is the commit message #27:

testing

# This is the commit message #28:

testing

# This is the commit message #29:

testing

# This is the commit message #30:

testing

# This is the commit message #31:

testing

# This is the commit message #32:

testing

# This is the commit message #33:

testing

# This is the commit message #34:

testing

# This is the commit message #35:

testing

# This is the commit message #36:

testing

# This is the commit message #37:

testing

# This is the commit message #38:

testing

# This is the commit message #39:

testing

# This is the commit message #40:

testing

# This is the commit message #41:

testing

# This is the commit message #42:

testing

# This is the commit message #43:

testing

# This is the commit message #44:

fixes

# This is the commit message #45:

fixes

# This is the commit message #46:

fixes

# This is the commit message #47:

fixes

# This is the commit message #48:

fixes

# This is the commit message #49:

fixes

# This is the commit message #50:

fixes

# This is the commit message #51:

fixes

# This is the commit message #52:

fixes

# This is the commit message #53:

fixes

# This is the commit message #54:

fixes

# This is the commit message #55:

fixes

# This is the commit message #56:

fixes

# This is the commit message #57:

fixes

# This is the commit message #58:

fixes

# This is the commit message #59:

fixes

# This is the commit message #60:

fixes

# This is the commit message #61:

fixes

# This is the commit message #62:

fixes

# This is the commit message #63:

fixes

# This is the commit message #64:

fixes

# This is the commit message #65:

fixes

# This is the commit message #66:

fixes

# This is the commit message #67:

fixes

# This is the commit message #68:

fixes

# This is the commit message #69:

fixes

# This is the commit message #70:

fixes

# This is the commit message #71:

fixes

# This is the commit message #72:

fixes

# This is the commit message #73:

fixes

# This is the commit message #74:

fixes

# This is the commit message #75:

fixes

# This is the commit message #76:

fixes

# This is the commit message #77:

fixes

# This is the commit message #78:

fixes

# This is the commit message #79:

more testing

# This is the commit message #80:

testing

# This is the commit message #81:

fixes

# This is the commit message #82:

fixes

# This is the commit message #83:

fixes

# This is the commit message #84:

fixes

# This is the commit message #85:

fixes

# This is the commit message #86:

fixes

# This is the commit message #87:

fixes

# This is the commit message #88:

fixes

# This is the commit message #89:

fixes

# This is the commit message #90:

fixes

# This is the commit message #91:

fixes

# This is the commit message #92:

fixes

# This is the commit message #93:

propagate-environment for buildkite-agent

# This is the commit message #94:

propagate-environment for buildkite-agent

# This is the commit message #95:

propagate-environment for buildkite-agent

# This is the commit message #96:

propagate-environment for buildkite-agent

# This is the commit message #97:

fixes

# This is the commit message #98:

fixes

# This is the commit message #99:

fixes

# This is the commit message #100:

fixes

# This is the commit message #101:

fixes

# This is the commit message #102:

fixes

# This is the commit message #103:

fixes

# This is the commit message #104:

fixes

# This is the commit message #105:

fixes

# This is the commit message #106:

fixes

# This is the commit message #107:

fixes

# This is the commit message #108:

fixes

# This is the commit message #109:

fixes

# This is the commit message #110:

fixes

# This is the commit message #111:

fixes

# This is the commit message #112:

fixes

# This is the commit message #113:

fixes

# This is the commit message #114:

fixes

# This is the commit message #115:

fixes

# This is the commit message #116:

fixes

# This is the commit message #117:

fixes

# This is the commit message #118:

fixes

# This is the commit message #119:

fixes

# This is the commit message #120:

fixes

# This is the commit message #121:

fixes

# This is the commit message #122:

fixes

# This is the commit message #123:

fixes

# This is the commit message #124:

fixes

# This is the commit message #125:

fixes

# This is the commit message #126:

fixes

# This is the commit message #127:

fixes

# This is the commit message #128:

fixes

# This is the commit message #129:

fixes

# This is the commit message #130:

fixes

# This is the commit message #131:

fixes

# This is the commit message #132:

fixes

# This is the commit message #133:

fixes

# This is the commit message #134:

fixes

# This is the commit message #135:

fixes

# This is the commit message #136:

fixes

# This is the commit message #137:

fixes

# This is the commit message #138:

fixes

# This is the commit message #139:

fixes

# This is the commit message #140:

fixes

# This is the commit message #141:

fixes

# This is the commit message #142:

fixes

# This is the commit message #143:

fixes

# This is the commit message #144:

fixes

# This is the commit message #145:

fixes

# This is the commit message #146:

fixes

# This is the commit message #147:

fixes

# This is the commit message #148:

fixes

# This is the commit message #149:

fixes

# This is the commit message #150:

fixes

# This is the commit message #151:

fixes

# This is the commit message #152:

fixes

# This is the commit message #153:

testing

# This is the commit message #154:

fixes

# This is the commit message #155:

fixes

# This is the commit message #156:

fixes

# This is the commit message #157:

fixes

# This is the commit message #158:

fixes

# This is the commit message #159:

fixes

# This is the commit message #160:

fixes

# This is the commit message #161:

fixes

# This is the commit message #162:

fixes

# This is the commit message #163:

fixes

# This is the commit message #164:

fixes

# This is the commit message #165:

fixes

# This is the commit message #166:

fixes

# This is the commit message #167:

fixes

# This is the commit message #168:

fixes

# This is the commit message #169:

fixes

# This is the commit message #170:

fixes

# This is the commit message #171:

fixes

# This is the commit message #172:

fixes

# This is the commit message #173:

fixes

# This is the commit message #174:

fixes

# This is the commit message #175:

fixes

# This is the commit message #176:

fixes

# This is the commit message #177:

fixes

# This is the commit message #178:

fixes

# This is the commit message #179:

fixes

# This is the commit message #180:

fixes

# This is the commit message #181:

fixes

# This is the commit message #182:

fixes

# This is the commit message #183:

fixes

# This is the commit message #184:

fixes

# This is the commit message #185:

fixes

# This is the commit message #186:

fixes
Frank-AFN pushed a commit to eosiosg/eos that referenced this pull request Mar 6, 2020
@Thaipanda
Merge pull request EOSIO#137 from eosswedenorg/bos-pkg-info
3345857 
CMakeModules/package.cmake: Update information.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@pmesnier pmesnier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nathanielhourt @bytemaster @pmesnier @kalloc @peterwillcn @iamaprotoss