This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Interpret uint64_t key string first as number before then trying to interpret it as a name #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring as a number before attempting to treat it as a name #3982 names consisting of only digits can still be provided by adding whitespace before or after the string containing the name
heifner
approved these changes
Jun 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3982.
This reordering of attempts in
convert_to_type<uint64_t>is more convenient to the user because names consisting of only digits should be rare.Ambiguity of account names consisting of only digits can still be resolved. It requires the user to add whitespace to the beginning and/or end of the name in the input string.