This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Remove wallet unlock unlock-timeout option #4139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhag
approved these changes
Jun 15, 2018
|
Is there any way I can keep wallet open all the time? Running local node |
|
@coolmagic You may specify a very long |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleos wallet unlock has a --unlock-timeout option but this option only does something if the wallet is not already running. If you do anything else first, like say cleos wallet open this is silently ignored.
Remove this option until it can be supported via rpc interface on keosd. This could possibly confuse users into thinking their wallet will be locked quickly when it will not be.