This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Password and keys to file instead of console #4819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
reviewed
Jul 23, 2018
programs/cleos/main.cpp
Outdated
| } | ||
| }); | ||
| create_key->add_flag( "--r1", r1, "Generate a key using the R1 curve (iPhone), instead of the K1 curve (Bitcoin)" ); | ||
| create_key->add_option("-f,--file", key_file, localized("Name of file to write wallet password output to. (Must be set, unless \"--to-console\" is passed")); | ||
| create_key->add_flag( "--to-console", print_console, localized("Print password to console.")); |
There was a problem hiding this comment.
"Print private/public keys to console"
heifner
reviewed
Jul 23, 2018
programs/cleos/main.cpp
Outdated
| } | ||
| }); | ||
| create_key->add_flag( "--r1", r1, "Generate a key using the R1 curve (iPhone), instead of the K1 curve (Bitcoin)" ); | ||
| create_key->add_option("-f,--file", key_file, localized("Name of file to write wallet password output to. (Must be set, unless \"--to-console\" is passed")); |
There was a problem hiding this comment.
"Name of file to write private/public key output ....
heifner
approved these changes
Jul 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4554
Changed "wallet create" and "create key" to take a "--file" parameter to pass a filename to write to or else to require "--to-console" to be passed to explicitly indicate sensitive information should be displayed on the console.