This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
remove producer-subjectivness from leeway #5071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
producer plugin was treating leeway cpu exceptions as subjective which in turn implies to the rest of the producer code that the block is exhausted. However, this exception rarely clears in a fresh block (only on wall-clock wobble) so it is in-appropriate for the producer plugin to consider this "subjective"
arhag
approved these changes
Aug 6, 2018
heifner
approved these changes
Aug 6, 2018
wanderingbort
deleted the
feature/leeway-exceptions-are-not-producer-subjective
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
producer plugin was treating leeway cpu exceptions as subjective which in turn implies to the rest of the producer code that the block is exhausted. However, this exception rarely clears in a fresh block (only on wall-clock wobble) so it is in-appropriate for the producer plugin to consider this "subjective"