This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Log which peer gives unexpected length messages #5097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a quicker understanding of which peer is misbehaving, allowing faster turnaround time to blocking bad peers.
heifner
reviewed
Aug 8, 2018
plugins/net_plugin/net_plugin.cpp
Outdated
| @@ -2122,7 +2122,7 @@ namespace eosio { | |||
| auto index = conn->pending_message_buffer.read_index(); | |||
| conn->pending_message_buffer.peek(&message_length, sizeof(message_length), index); | |||
| if(message_length > def_send_buffer_size*2 || message_length == 0) { | |||
| elog("incoming message length unexpected (${i})", ("i", message_length)); | |||
| elog("incoming message length unexpected (${i}), from ${p}", ("i", message_length)("p",boost::lexical_cast<std::string>(conn->socket->remote_endpoint()))); | |||
There was a problem hiding this comment.
This can throw an exception which will be caught below and report std::exception below. Pass boost::system::error_code ec; to remote_endpoint(ec); to avoid exception.
|
Updated -- I'm not sure that it can cause an exception there without excepting on the connection close, but good to squash it anyways I suppose. |
heifner
approved these changes
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a quicker understanding of which peer is misbehaving, allowing faster turnaround time to blocking bad peers.