This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Remove WAST support from cleos set code/contract #5160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The textual format of WebAssembly continues to be somewhat fluid. For example, the renaming of grow_memory with memory.grow. The binary format has been stable for some time. Only consume the binary format in cleos now -- the eosio tools (like eosiocpp) have produced binary .wasm files since the 1.0 release by default as do most other toolchains. This protects us from further deviations of the textual format
heifner
reviewed
Aug 10, 2018
programs/cleos/main.cpp
Outdated
| std::cerr << localized(("Reading WASM from " + wasmPath + "...").c_str()) << std::endl; | ||
| fc::read_file_contents(wasmPath, wast); | ||
| EOS_ASSERT( !wast.empty(), wast_file_not_found, "no wasm file found ${f}", ("f", wasmPath) ); | ||
| vector<uint8_t> wasm = vector<uint8_t>(wast.begin(), wast.end()); |
There was a problem hiding this comment.
Somewhat minor, but wast variable should be wasm
heifner
approved these changes
Aug 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The textual format of WebAssembly continues to be somewhat fluid. For example, the renaming of
grow_memorywithmemory.grow. The binary format has been stable for some time. Only consume the binary format in cleos now -- the eosio tools (like eosiocpp) have produced binary .wasm files since the 1.0 release by default as do most other toolchains. This protects us from further deviations of the textual format