This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Added LLVM_DIR for OSX #6258
Merged
Added LLVM_DIR for OSX #6258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhag
reviewed
Nov 19, 2018
CMakeModules/EosioTester.cmake.in
Outdated
| if (UNIX) | ||
| if (APPLE) | ||
| if (LLVM_DIR STREQUAL "" OR NOT LLVM_DIR) | ||
| set(LLVM_DIR "/usr/local/Cellar/llvm@4/4.0.1/lib/cmake/llvm") |
There was a problem hiding this comment.
Why not have the path be /usr/local/opt/llvm@4/lib/cmake/llvm? That way you don't have a dependency on the particular minor and patch release of LLVM? And that symlink should exist even if the user brew unlinks llvm@4.
Same goes for the path in EosioTesterBuild.cmake.in.
arhag
approved these changes
Nov 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Added LLVM_DIR fix for EosioTester, this points EosioTester directly to where llvm 4.0 is installed on Mac OSX.
Consensus Changes
API Changes
Documentation Additions