This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Improve error handling when writing out protocol features #7167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… JSON to a file path that already exist rather than trying with another name
…tocol features or genesis state)
larryk85
approved these changes
Apr 19, 2019
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Exit with error if a file exists at the intended path to write out the default protocol feature specification JSON rather than trying again with a modified path name. Also, log error message if unable to successfully write out the file, but still proceed forward since it is not a fatal error.
Also exits with appropriate error message if it was not successful in writing out the genesis state JSON.
Consensus Changes
API Changes
Documentation Additions