This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Gives a timeout for bios node check pulse and also minor cleanup on Cluster.py #7208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriantolie
changed the title
andriantolie
force-pushed
the
cluster-py-cleanup
branch
from
6891baf to
68a7c53
Compare
heifner
approved these changes
Apr 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives a timeout for biosNode.checkPulse as I occasionally see the test fails with
ERROR: Bios node doesn't appear to be running...error messageAnd also minor cleanup on Cluster.py. discoverLocalNode was using undefined timeout variable previously and returned inappropriate type when it fails to pgrep the process
Change Description
Consensus Changes
API Changes
Documentation Additions