Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Handle cases where version_* not specified in CMakeLists.txt - develop #8075

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Handle cases where version_* not specified in CMakeLists.txt - develop #8075

merged 2 commits into from
Oct 15, 2019

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Oct 15, 2019

Change Description

  • When version_suffix not specified in CMakeLists.txt version was reported as v2.0.0-
  • Fix reported version not to have trailing separators unless specific portion of version is specified.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@heifner heifner changed the title Handle cases where version_* not specified in CMakeLists.txt - develop Handle cases where version_* not specified in CMakeLists.txt - develop Oct 15, 2019
@heifner heifner merged commit 1b917aa into develop Oct 15, 2019
@heifner heifner deleted the version-suffix-dev branch October 15, 2019 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arhag arhag arhag approved these changes

@jgiszczak jgiszczak jgiszczak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heifner @arhag @jgiszczak