Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Debian Package: Make sure root is owner/group when building dpkg. #8151

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

pnx
Copy link
Contributor

@pnx pnx commented Oct 31, 2019

Change Description

Just passing --root-owner-group to dpkg in scripts/generate_deb.sh. Without this flag files in the .deb files are owned by the user running the script.

The official .deb files from this repo has root as owner group. so this change should just make it easier to create the same packages as the official ones.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@NorseGaud
Copy link
Contributor

NorseGaud commented Nov 6, 2019

Regarding the Travis failure: Mac tests failed for some memory reasons. Likely a transient problem, so I'm restarting the job.

Update after second run: Failed again with what looks like the same problem.

@pnx
Copy link
Contributor Author

pnx commented Nov 7, 2019

Regarding the Travis failure: Mac tests failed for some memory reasons. Likely a transient problem, so I'm restarting the job.

Update after second run: Failed again with what looks like the same problem.

Just to be sure. this should not be related to this PR right?

@spoonincode
Copy link
Contributor

@pnx I merged this but we're going to have to back it out since it appears 16.04 does not support --root-owner-group. If you can come up with something that works on both we can reconsider it; I think it's a good fix.

@pnx
Copy link
Contributor Author

pnx commented Jan 8, 2020

@pnx I merged this but we're going to have to back it out since it appears 16.04 does not support --root-owner-group. If you can come up with something that works on both we can reconsider it; I think it's a good fix.

@spoonincode See #8408

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants