This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Extend shutdown allowed time in under min available resources test #8306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
suggested changes
Dec 10, 2019
tests/Node.py
Outdated
| return False | ||
| except PermissionError as ex: | ||
| if logStatus: Utils.Print("Determined node(formerly pid=%s) is killed" % (pid)) |
There was a problem hiding this comment.
This should say "is alive", right?
tests/Node.py
Outdated
| return True | ||
|
|
||
| if logStatus: Utils.Print("Determined node(pid=%s) is alive (kill command executed)" % (self.pid)) |
There was a problem hiding this comment.
This didn't call kill, well technically it did, but the kill is kill 0 which is just check the status. I think you should remove "(kill command executed)"
heifner
approved these changes
Dec 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fixed corner case for failures and added debug logging. And increase time allowed to shutdown.
Consensus Changes
API Changes
Documentation Additions