Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[develop] Modified Amazon and Centos to use yum install ccache #8405

Merged
merged 6 commits into from
Jan 7, 2020

Conversation

NorseGaud
Copy link
Contributor

@NorseGaud NorseGaud commented Jan 7, 2020

Change Description

Modified Amazon and Centos to use yum install ccache. This way the rpm doesn't get removed and fail our builds.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

Copy link
Contributor

@spoonincode spoonincode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it's just going to break again in the future when EPEL bumps the version again. Can we properly install the EPEL repo (https://fedoraproject.org/wiki/EPEL) and do a yum install that way?

@NorseGaud
Copy link
Contributor Author

This seems like it's just going to break again in the future when EPEL bumps the version again. Can we properly install the EPEL repo (https://fedoraproject.org/wiki/EPEL) and do a yum install that way?

Including EPEL has an impact on more than just ccache; That is a larger effort we can discuss separately from this fix to unblock your branch.

@kj4ezj
Copy link
Contributor

kj4ezj commented Jan 7, 2020

Including EPEL has an impact on more than just ccache; That is a larger effort we can discuss separately from this fix to unblock your branch.

Is it not just two commands?

yum install epel-release
yum install ccache

What are the other implications? I think we should discuss them now and fix it right the first time.

@spoonincode
Copy link
Contributor

I think the concern I would have is that something in EPEL conflicts with non-EPEL. They have a pretty clear policy about this
https://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Policy_for_Conflicting_Packages
which makes it sound like a conflict between SCL & EPEL might be the only possibility that could bite us. Indeed, EPEL includes an llvm7 package just like SCL includes an llvm7 package (which is that one we're using today).

There are probably ways of mitigating this risk: like Nathan suggests, enabling EPEL just before installing ccache -- after the other installations.

@NorseGaud NorseGaud changed the title [develop] Modified Amazon and Centos to use ccache-3.7.6-1.el7.x86_64.rpm instead of 3.3.4 [develop] Modified Amazon and Centos to use yum install ccache Jan 7, 2020
@NorseGaud NorseGaud merged commit 58dd026 into develop Jan 7, 2020
@NorseGaud NorseGaud deleted the develop-ccache-version-fix branch January 7, 2020 21:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants