This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
remove WAVM runtime - 2.0 #8407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
In the release notes of 2.0.0-rc1 WAVM was deprecated and scheduled for future removal. That depreciation was over 3 months ago — I would like to go ahead and remove WAVM before 2.0.0 final so that we do not potentially need to support it for another handful of months. EOS VM JIT and EOS VM OC have, as anticipated, shown themselves to be better replacements during the 2.0.0 rc period.
This PR contains backports of the three commits from #8047, #8115, and #8136 that disable and remove much of the WAVM runtime. These commits have been in develop 2-3 months so they have been somewhat battle tested.
Consensus Changes
API Changes
Documentation Additions