Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[develop] Fix installation location of header file eosio.version.hpp #8433

Merged
merged 2 commits into from
Jun 6, 2020

Conversation

johndebord
Copy link
Contributor

Fixes #8280. eosio.version.hpp now, by default, installs in directory /usr/local/include/eosio/, as opposed to /usr/local/include/.

@johndebord johndebord changed the title Fix installation location of header file eosio.version.hpp develop Fix installation location of header file eosio.version.hpp Jan 11, 2020
@johndebord johndebord changed the title develop Fix installation location of header file eosio.version.hpp [develop] Fix installation location of header file eosio.version.hpp Jan 11, 2020
@swatanabe-b1
Copy link
Contributor

If you're renaming it, eosio/version.hpp would be better. There's no reason to duplicate the eosio.

@heifner
Copy link
Contributor

heifner commented Mar 12, 2020

@johndebord can we move this forward?

@johndebord
Copy link
Contributor Author

johndebord commented Mar 12, 2020

@johndebord can we move this forward?

Yes, I believe we can. But I suppose I will take @swatanabe-b1's suggestion and rename the file to version.in as opposed to it being eosio.version.in. So I'll make those three commits on the three branches and run the tests to make sure everything still works.

@swatanabe-b1
Copy link
Contributor

Also, version.hpp doesn't compile.

@jeffreyssmith2nd
Copy link
Contributor

Rebased and force pushed to get the latest CI to run so we can merge.

@jeffreyssmith2nd jeffreyssmith2nd merged commit cd52e31 into develop Jun 6, 2020
@jeffreyssmith2nd jeffreyssmith2nd deleted the eosio-version-header-fix branch June 6, 2020 10:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants