Remove new block id notify feature - 2.0 #8471

heifner · 2020-01-19T00:26:08Z

Change Description

Remove new block id notify feature as it doesn't actually improve performance and actually causes issues with large # of connections.
Since this was the only new net protocol feature added in 2.0, the net protocol version has been reverted to 1.8 .. 1.0 version.
Do not send blocks when syncing with peer.
Fix first sync asking for less than lib.

…e rather than improve it.

…sure it is at least lib

Remove new block id notify feature as it actually degrades performanc…

0f29b79

…e rather than improve it.

brianjohnson5972 approved these changes Jan 19, 2020

View reviewed changes

heifner added 3 commits January 20, 2020 07:42

Do not broadcast block if syncing with peer

72c1e0d

Syncing can start without an updated sync_next_expected_num, so make …

12c4a37

…sure it is at least lib

Always send a handshake on unlinkable block

6ed50e1

heifner merged commit feb6636 into release/2.0.x Jan 25, 2020

heifner deleted the block-id-notify-revert-2.0 branch January 25, 2020 03:51