This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Drop late blocks - develop #8497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
New policy for dropping all incoming blocks while producing blocks. This prevents extra work by BPs from
abort_blockand is far simpler than attempting to determine if the incoming block is potentially relevant to the chain.Since this sets up a situation where the last block, if received late, is likely to be dropped, this PR also changes the default value for last block time offset to -200000us. BPs who have already explicitly set the
last-block-time-offset-usparameter may want to re-evaluate in light of this change.Succinctly, It is now the default policy that BPs are responsible for shipping out their last block(s) early enough such that the next BP will receive them before they start producing or risk having their work dropped.
Co-Authored-By: Bart Wyatt bart.wyatt@block.one
Co-Authored-By: Kevin Heifner heifnerk@objectcomputing.com
Consensus Changes
API Changes
Documentation Additions