Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Move parts of state-history-plugin to libraries/state_history #8750

Merged
merged 19 commits into from
May 4, 2020

Conversation

tbfleming
Copy link
Contributor

@tbfleming tbfleming commented Mar 4, 2020

Change Description

This moves some parts of ship's logic into a library so the newest new CDT tester may include it.

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@tbfleming tbfleming marked this pull request as ready for review March 16, 2020 17:49
@tbfleming tbfleming mentioned this pull request Apr 28, 2020
3 tasks
libraries/state_history/CMakeLists.txt Outdated Show resolved Hide resolved
libraries/state_history/trace_converter.cpp Outdated Show resolved Hide resolved
@gleehokie
Copy link
Contributor

@tbfleming should the new directory be named libraries/state-history instead of libraries/state_history (dash instead of underscore)? We use "-" as the separator for directory names in the eos repo currently.

@tbfleming
Copy link
Contributor Author

@gleehokie state-history isn't a valid namespace name and I thought it'd get confusing to have a directory name subtly different.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants