This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
wabt: don't search for python because we don't run tests #8864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
wabt used python 2.7 for its unittests, but we never built nor ran its tests. Regardless, its CMakeLists.txt was searching for python 2.7. Remove that requirement from its cmake. This is an attempt to get ahead of modern distros (like Ubuntu 20.04) removing python 2.7 and making it tricky for users to build.
Please also approve EOSIO/wabt#11 once happy.
Consensus Changes
API Changes
Documentation Additions