This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Resource monitor plugin -- develop branch #9196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and integration test cases, terminate thread right after plugin shutdown, and make apps register monitored directories
…nge bash script to python tomorrow)
…n test from Bash to Python next), make shutdown on exceeding threshold as default, increase interval upper bound to 5 minutes
…e_monitor_plugin_impl, changed integration test script from Bash to Python
…and relax timing requirements for test cases
linhuang-blockone
requested review from
heifner,
larryk85,
spoonincode and
b1bart
larryk85
suggested changes
Jun 11, 2020
larryk85
approved these changes
Jun 11, 2020
This was referenced May 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This is a replicated PR of #9098 for develop branch.
Only differences are enabling resource monitor plugin by default for future releases, creating
new test cases for it, and moving resource_monitor_impl back to resource_monitor_plugin.cpp
to be consistent with other plugins.
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions
Configurable Parameters
resource-monitor-interval-seconds
Time in seconds between two consecutive checks of resource usage. It should be between 1 and 300 (5 minutes). This is optional; the default value is 2 seconds.
resource-monitor-space-threshold
Threshold in terms of percentage of used space vs total space. If used space is above (threshold - 5%), a warning is generated. If used space is above the threshold and resource-monitor-not-shutdown-on- threshold-exceeded is enabled, a graceful shutdown is initiated. The value should be between 6 and 99
resource-monitor-not-shutdown-on-threshold-exceeded
Used to indicate nodeos will not shutdown when threshold is exceeded.