This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Improve parsing of RabbitMQ-related command line arguments in rodeos - develop #9217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tightens up parsing of RabbitMQ-related command line arguments (it simplifies the code, improves readability, and adds a comment and a unit test).
revl
changed the title
heifner
reviewed
Jun 17, 2020
heifner
reviewed
Jun 17, 2020
Using this type of exchange is a bit more involved than just declaring the exchange type as 'topic'.
Per request on the pull request
|
It's been confirmed that this commit also fixes the Linux SEGFAULT. |
Confirmed to be working fine on Ubuntu 20.04, which previously had segfault issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This commit tightens up parsing of RabbitMQ-related command line arguments (it simplifies the code, improves readability, and adds a comment and a unit test).
Change Type
On Linux, specifying
--stream-rabbits-exchangecrashes rodeos with SEGFAULT. On macOS, it was observed that the log contained "RabbitMQ Connected Successfully! Exchange �". Apparently, there's a read access of deleted memory in the onSuccess lambda. It can no longer be reproduced after this commit. If this commit doesn't fix the Linux bus error, I'll investigate it separately.Consensus Changes
API Changes
Documentation Additions
A comment to
parse_rabbitmq_addressinrabbitmq.hppexpands a little bit on the format of the argument of the rodeos options--stream-rabbitsand--stream-rabbits-exchange.