This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix log of pending block producer - develop #9222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjohnson5972
approved these changes
Jun 18, 2020
| @@ -1560,7 +1569,8 @@ bool producer_plugin_impl::remove_expired_trxs( const fc::time_point& deadline ) | |||
| if( pbm == pending_block_mode::producing ) { | |||
| fc_dlog( _trx_trace_log, | |||
| "[TRX_TRACE] Block ${block_num} for producer ${prod} is EXPIRING PERSISTED tx: ${txid}", | |||
| ("block_num", chain.head_block_num() + 1)("prod", chain.pending_block_producer())("txid", txid)); | |||
| ("block_num", chain.head_block_num() + 1)("txid", txid) | |||
| ("prod", chain.is_building_block() ? chain.pending_block_producer() : name()) ); | |||
There was a problem hiding this comment.
Is there a reason you don't use the new method here as well?
There was a problem hiding this comment.
impl this not available and I didn't want to have to calculate it and pass it in when most of the time logging is off and it is not needed.
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
transaction_tracingdebug level logging enablednodeoscan EOS_ASSERT from trying to log the pending block producer when no pending block is available.developversion of Fix log of pending block producer - 2.0 #9223Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions