This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Remove Concurrency Groups for Scheduled Builds #9263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This pull request removes agent concurrency groups from the CI pipelines for scheduled builds.
Background
Buildkite concurrency groups allow engineers to limit the number of build agents that specific systems consume simultaneously. Previously, we placed concurrency limits on scheduled builds in EOSIO because, sometimes, scheduled builds would consume all available macOS agents when we were trying to cut a release.
Problem
Today, we have a large number of scheduled builds that kick off in the middle of the night. While our CI system can easily run all those builds before anyone comes into work, we've seen days where the builds didn't finish until after lunch due to artificial constraints caused by concurrency groups.
Solution
We are removing the concurrency groups altogether, having decided an occasional manual schedule adjustment or build cancellation is worth faster scheduled builds and simplified pipeline code.
See Also
eos:developeos:release/2.1.xeos:release/2.0.xeos:develop-boxedChange Type
Select ONE
CI
Consensus Changes
None.
API Changes
None.
Documentation Additions
None.