This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
retrying_amqp_connection: commonize more amqp connection management stuff #9294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swatanabe-b1
reviewed
Jul 8, 2020
...retrying_amqp_connection/include/eosio/retrying_amqp_connection/retrying_amqp_connection.hpp
Outdated
Show resolved
Hide resolved
...retrying_amqp_connection/include/eosio/retrying_amqp_connection/retrying_amqp_connection.hpp
Outdated
Show resolved
Hide resolved
...retrying_amqp_connection/include/eosio/retrying_amqp_connection/retrying_amqp_connection.hpp
Outdated
Show resolved
Hide resolved
...retrying_amqp_connection/include/eosio/retrying_amqp_connection/retrying_amqp_connection.hpp
Outdated
Show resolved
Hide resolved
heifner
reviewed
Jul 9, 2020
| if (a.vhost() != "/") | ||
| str.append(a.vhost()); | ||
|
|
||
| v = str; |
There was a problem hiding this comment.
This could be: v = std::move(str); as fc::variant takes string by value.
& just support passing an io_context for now. Move most the impl to a .cpp since it's not templated any longer
heifner
reviewed
Jul 16, 2020
...retrying_amqp_connection/include/eosio/retrying_amqp_connection/retrying_amqp_connection.hpp
Outdated
Show resolved
Hide resolved
heifner
approved these changes
Jul 17, 2020
This was referenced Sep 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Getting a bit tired of copy pasting around some amqp connection management stuff in a few places. retrying_amqp_connection tries to solve the typical use case of needing a single channel connected to an AMQP server that is retried on failure. Compared to the code that was in reliable_amqp_publisher previously, a few functional differences are:
But there will likely be future improvements easier to add this way too, like TLS support with peer auth for example.
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions