Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add script support for CentOS 8 move to PR 9475 #9361

Closed
wants to merge 8 commits into from

Conversation

softprofe
Copy link
Contributor

@softprofe softprofe commented Aug 5, 2020

Change Description

Start 9361 description ......
move to PR 9475 #9475

In script eos/scripts/eosio_build.sh, line 122, set -i pop error on centos7 and conetos8, so, add OS judge and not use set -i on CentOS, tested can be built without "set -i";
In script eos/scripts/eosio_build_centos.sh, it regard centos version as 7 without judge, and install package which only can be used on centos 7. I add judge and install package which can be used on centos8. centos 7 will still install the original packages.
End 9361 description...

Change Type

Select ONE

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

if [[ "$(echo ${VERSION} | sed 's/ .*//g')" == 8 ]]; then
echo "Install Development Tools ..."
dnf install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-8.noarch.rpm
dnf group install -y "Development Tools"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as is, these will require the script to run as root

@spoonincode
Copy link
Contributor

spoonincode commented Aug 5, 2020

will not work on develop once #9198 is merged because it is lacking installation of llvm
(won't work as is on 2.0)

@softprofe
Copy link
Contributor Author

will not work on develop once #9198 is merged because it is lacking installation of llvm
(won't work as is on 2.0)

Based on my experience of build eos on Centos, after dnf group install -y "Development Tools", llvm will still be installed by ensure-llvm()

@spoonincode
Copy link
Contributor

llvm will still be installed by ensure-llvm()

Even for an unpinned build?

@spoonincode
Copy link
Contributor

My centos8 container was populated with a "minimal" install and interestingly failed to build because the lack of openssl dev being installed. Maybe we should add that as a installed package

@softprofe
Copy link
Contributor Author

My centos8 container was populated with a "minimal" install and interestingly failed to build because the lack of openssl dev being installed. Maybe we should add that as a installed package

Sure we can install openssl-dev for centos 8

@softprofe
Copy link
Contributor Author

llvm will still be installed by ensure-llvm()

Even for an unpinned build?

should not, because unpinned build don't need it I think.

@spoonincode
Copy link
Contributor

should not, because unpinned build don't need it I think.

If you merge develop in to this branch I think you'll find you need it

@softprofe
Copy link
Contributor Author

should not, because unpinned build don't need it I think.

If you merge develop in to this branch I think you'll find you need it
Why ensure-llvm() won't work?

@softprofe softprofe closed this Sep 7, 2020
@softprofe softprofe deleted the centos8_support branch September 7, 2020 23:15
@softprofe softprofe changed the title Add script support for CentOS 8 Add script support for CentOS 8 move to PR 9475 https://github.com/EOSIO/eos/pull/9475 Sep 8, 2020
@softprofe softprofe changed the title Add script support for CentOS 8 move to PR 9475 https://github.com/EOSIO/eos/pull/9475 Add script support for CentOS 8 move to PR 9475 Sep 8, 2020
softprofe added a commit that referenced this pull request Sep 11, 2020
Add script support for CentOS 8 (redo of #9361)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants