This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix template instantiation for host function #9416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larryk85
previously approved these changes
Aug 19, 2020
larryk85
dismissed
their stale review
The fix for the failure will need to be re-reviewed.
I have no idea why BOOST_HANA_CONFIG_ENABLE_STRING_UDL defined in instrinct_mapping.hpp doesn't work. This is the workaround I can find so far.
larryk85
suggested changes
Aug 20, 2020
larryk85
suggested changes
Aug 20, 2020
# Conflicts: # libraries/chain/include/eosio/chain/webassembly/eos-vm-oc/intrinsic_mapping.hpp # libraries/chain/include/eosio/chain/webassembly/interface.hpp
std::tuple_size_v<> only works for tuple, not for std::array for now. Library TS has it but not merged into the standard yet. |
larryk85
approved these changes
Aug 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Directly address the build time issue caused by the extra template instantiations for host function wrappers in multiple transaction units.
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions