This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
move is_string_valid_name to cpp file #9445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
reviewed
Aug 25, 2020
|
|
||
| return true; | ||
| } | ||
| bool is_string_valid_name(std::string_view str); |
There was a problem hiding this comment.
What about making it a constexpr instead?
There was a problem hiding this comment.
make it constexpr only make if it is called with the input parameter can be known at compile time. I don't see any of callers of the function meet that criteria except those in unit tests.
There was a problem hiding this comment.
Yeah, use case is likely not there.
kimjh2005
approved these changes
Aug 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
eosio::chain::is_string_valid_name() is static function in the header file which caused it be generated in every translation units include that header file. This PR fixes the problem.
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions